Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix provisioning #905

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Fix provisioning #905

merged 1 commit into from
Jul 26, 2024

Conversation

julien-nc
Copy link
Member

fixes #904

  • fix: make avatar provisioning safer (it was crashing when not set)
  • fix: use values from AttributeMappedEvent for all attributes
  • fix: don't use ID token attribute if it's null or an empty string
  • fix address logic
  • replace deprecated IUser::setEmailAddress by IUser::setSystemEMailAddress

@julien-nc julien-nc added the bug Something isn't working label Jul 26, 2024
@julien-nc julien-nc mentioned this pull request Jul 26, 2024
Closed
@julien-nc
fix(provisioning): make avatar provisioning safer, use values from At…
e508d5c 
…tributeMappedEvent for all attributes, fix address logic

Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc julien-nc force-pushed the fix/904/provisioning-attr-mistakes branch from e03ddaa to e508d5c Compare July 26, 2024 09:38
@julien-nc julien-nc merged commit c93eb4f into main Jul 26, 2024
38 checks passed
@julien-nc julien-nc deleted the fix/904/provisioning-attr-mistakes branch July 26, 2024 13:28
@julien-nc julien-nc mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to login if no avatar is provided
1 participant
@julien-nc